Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DQL heredoc support #141013

Closed
wants to merge 1 commit into from
Closed

Add DQL heredoc support #141013

wants to merge 1 commit into from

Conversation

eexit
Copy link

@eexit eexit commented Jan 19, 2022 •
edited
Loading

Hello,

This tiny PR adds support for Doctrine Query Language syntax coloration in heredocs.

Example:

dql-support

Thanks!

@rzhao271 rzhao271 assigned roblourens and unassigned rzhao271 Jan 19, 2022
@rzhao271 rzhao271 added the php PHP support issues label Jan 19, 2022
@roblourens
Copy link
Member

Thanks for the PR, but our php syntax is generated from this repo, so PRs should go upstream https://github.com/atom/language-php

@roblourens roblourens closed this Jan 20, 2022
@eexit
Copy link
Author

eexit commented Jan 20, 2022 •
edited
Loading

Ok, thanks for the info.
Opened here: atom/language-php#448

@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@roblourens roblourens

Labels
php PHP support issues triage-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eexit @roblourens @rzhao271