Skip to content

fix(git): fatal when adding, reverting files or cleaning repo on win32 [#108690] #108691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 16, 2020
Merged

fix(git): fatal when adding, reverting files or cleaning repo on win32 [#108690] #108691

merged 2 commits into from
Oct 16, 2020

Conversation

asn007
Copy link
Contributor

@asn007 asn007 commented Oct 14, 2020 •
edited
Loading

This PR fixes #108690 by adding invocations of sanitizePath to path preprocessing to methods add, revert and clean in Git class of Git client akin to how it's done in checkout, for example

@asn007 asn007 mentioned this pull request Oct 14, 2020
Closed
@joaomoreno joaomoreno added the git GIT issues label Oct 16, 2020
joaomoreno
joaomoreno approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🍻

@joaomoreno joaomoreno added this to the October 2020 milestone Oct 16, 2020
@joaomoreno joaomoreno merged commit b71ede6 into microsoft:master Oct 16, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

Assignees

@joaomoreno joaomoreno

Labels
git GIT issues
Projects
None yet
Milestone
October 2020
Development

Successfully merging this pull request may close these issues.

Git on Windows: fatal when adding or removing files due to drive lowercase letter
2 participants
@asn007 @joaomoreno