Skip to content

Add keybinding shortcut for "Preserve case" replace option #107597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2020
Merged

Add keybinding shortcut for "Preserve case" replace option #107597

merged 3 commits into from
Oct 6, 2020

Conversation

turara
Copy link
Contributor

@turara turara commented Sep 28, 2020

This PR resolves #107208 with

  • Adding "togglePreserveCase" command actions for editor and search view with default keybinding of "alt-(cmd)-p"
  • Adding keybinding label to ReplaceInput and ContextScopedReplaceInput classes.

@ghost
Copy link

ghost commented Sep 28, 2020 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@turara
Copy link
Contributor Author

turara commented Sep 29, 2020

Related to #107588.

@turara
Copy link
Contributor Author

turara commented Sep 29, 2020

Is there anything I need to do about the failure of VS Code check?

@roblourens roblourens assigned roblourens and unassigned rebornix Sep 29, 2020
@roblourens roblourens requested a review from rebornix September 29, 2020 17:07
@roblourens
Copy link
Member

roblourens commented Sep 29, 2020 •
edited
Loading

Looks good to me but we are in our endgame week for the next release and I will review and merge it next week. The CI failure looks unrelated.

@turara
Copy link
Contributor Author

turara commented Sep 30, 2020 •
edited
Loading

Thanks! I see 😃

@roblourens roblourens added this to the October 2020 milestone Sep 30, 2020
@roblourens roblourens merged commit c7c471b into microsoft:master Oct 6, 2020
@turara
Copy link
Contributor Author

turara commented Oct 6, 2020

@roblourens Thank you for reviewing and merging! This is my first decent contribution to OSS. I'm very happy 😃

@roblourens
Copy link
Member

Congratulations! I hope to see more from you 😁

@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rebornix rebornix Awaiting requested review from rebornix

Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
October 2020
Development

Successfully merging this pull request may close these issues.

"Preserve case" replace option : add a key shortcut
3 participants
@turara @roblourens @rebornix