${file} - must be the current opened file, but points to the name of output pane

[vorfol]

Issue Type: Bug

I have a launch configuration that uses predefined variable ${file}. I suppose ${file} must point to the file in the active edit window, but if the cursor is in the output pane, the variable ${file} points to the name of output pane when I press 'F5'.

configuration in launch.json to test:

{
            "name": "(Windows) Launch",
            "type": "cppvsdbg",
            "request": "launch",
            "program": "cmd",
            "args": ["/c","echo", "${file}"],
            "stopAtEntry": false,
            "cwd": "${workspaceFolder}",
            "environment": [],
            "externalConsole": false
}

VS Code version: Code 1.44.1 (a9f8623, 2020-04-11T01:48:12.622Z)
OS version: Windows_NT x64 10.0.18363

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-5200U CPU @ 2.20GHz (4 x 2195)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled viz_display_compositor: enabled_on viz_hit_test_surface_layer: disabled_off_ok webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	7.88GB (1.66GB free)
Process Argv	--folder-uri file:///c%3A/work/vms_ide/vms-ide
Screen Reader	no
VM	50%

Extensions (10)

Extension	Author (truncated)	Version
Kotlin	mat	1.7.1
vscode-antlr4	mik	2.2.3
csharp	ms-	1.21.17
python	ms-	2020.3.71659
cpptools	ms-	0.27.0
platformio-ide	pla	1.10.0
scala	sca	0.3.9
rst-vscode	tht	3.0.1
sort-lines	Tyr	1.9.0
hex-ascii-converter	yrp	0.0.1

[isidorn]

So $file should resolve to the editor and not to the output (which is also an editor).
I think this overall makes sense and forwarding to @alexr00 as this is variable-resolving.

[alexr00]

@jrieken it looks like ExtHostDocumentsAndEditors will return non-code editors as the activeEditor.

vscode/src/vs/workbench/api/common/extHostDebugService.ts

Lines 994 to 1000 in 958a942

	getFilePath: (): string | undefined => {
	const activeEditor = editorService.activeEditor();
	if (activeEditor) {
	return path.normalize(activeEditor.document.uri.fsPath);
	}
	return undefined;
	},

Is there a way to get just the active user editor (as apposed to things that the user doesn't think of as editors)?

[isidorn]

@alexr00 I think we were always behaving like that.
When you do the resolving can you use the editorService, or you have to go to the exHost one?
Since the editorService has the activeEditor
Not sure if there is something on the exHost side for the same behavior

[alexr00]

@isidorn the ExtHostDebugService is only resolving these variables in the extension host, and not going to the renderer. If debug can go to the renderer for this resolving then that would fix this too, since I couldn't reproduce with tasks (which resolves in the renderer).

[isidorn]

fyi @weinand

[weinand]

I'll take care of this.