EditorGroupService.replaceEditors unexpectedly type casts argument type

[mjbvz]

Issue Type: Bug

Bug
In EditorGroupService, the replaceEditors implementation takes a EditorReplacement. However the public IEditorReplacement.replaceEditors api only requires a IEditorReplacement.

This means that our implementation is performing a hidden type cast that can cause unexpected runtime errors

VS Code version: Code - Insiders 1.39.0-insider (b7a5b7c, 2019-09-12T08:43:00.105Z)
OS version: Darwin x64 18.7.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status	2d_canvas: enabled flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled oop_rasterization: disabled_off protected_video_decode: unavailable_off rasterization: enabled skia_deferred_display_list: disabled_off skia_renderer: disabled_off surface_synchronization: enabled_on video_decode: enabled viz_display_compositor: disabled_off webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	16.00GB (0.03GB free)
Process Argv	-psn_0_4576349
Screen Reader	no
VM	0%

[bpasero]

I am not seeing an issue with that because it looks like TS is happy with how the interface of IEditorGroupView is implemented. There is a lot more cases in the editor group view where the type is referred to and not the interface (e.g. IEditorInput vs EditorInput). I would prefer to keep it like that.

[mjbvz]

Here's an example of how the existing code causes problems:

vscode/src/vs/workbench/contrib/customEditor/browser/customEditors.ts

Line 133 in ebe12f5

options: options ? EditorOptions.create(options) : undefined,

Without the call EditorOptions.create, we get a crash when trying to invoke EditorOptions.override() on a normal IEditorOptions object. I wish TS did not allow this but its type system currently does since the EditorOptions used by the implementation implements IEditorOptions used by the interface

[bpasero]

@mjbvz everything should be OK if you go through the IEditorService interface, no? Because we do:

vscode/src/vs/workbench/services/editor/browser/editorService.ts

Line 366 in d3fe5cc

private toOptions(options?: IEditorOptions | EditorOptions): EditorOptions {

Maybe you can give me some code that shows the issue for me to reproduce.

[vscodebot]

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!