Skip to content

Minifier: remove hoist_funs: true configuration once it is safe #80202

Closed
@bpasero

Description

@bpasero

When we minify, we have to pass in hoist_funs: true, otherwise we get below results:

image

Somehow our json parser stumbles over our language configurations otherwise. I have not fully figured out why that is, but this is something we should follow up.

To reproduce:

  • search for hoist_funs: true in build/lib/optimize.ts and change it to false
  • yarn gulp vscode-darwin-min
  • run the minified build

//cc @chrmarti

Metadata

Metadata

Assignees

Labels

debtCode quality issuesupstreamIssue identified as 'upstream' component related (exists outside of VS Code)

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions