Try migrating off of tsb and using normal tsc for building VS Code

[mjbvz]

VS Code currently use the gulp-tsb library for building VS Code. This library has some capability problems with some typescript features (jrieken/gulp-tsb#81).

We should investigate if normal tsc --watch --incremental is now fast enough for the main VS Code build

/cc @rbuckton @weswigham

[mjbvz]

I believe that @rbuckton mentioned that TypeScript is using gulp + normal tsc. Relevant code: https://github.com/microsoft/TypeScript/blob/47182b543a2a0af7c71b9a098ceb4c419d745e2e/Gulpfile.js#L24

[weswigham]

Probably worth noting: our infra around our build is way more complex than your probably needs to be, since we needed to wrap tsc -b, and lift project dependency semantics from gulp dependencies into project reference dependencies. Y'all probably don't need any of that and could just exec("tsc --watch --incremental").

[jrieken]

• Bring tsconfig.json in a state that allows to compile via npx tsc -p src/tsconfig.json. That's not possible due to some d.ts conflicts
• Measure & compare... E.g. measure on different OSes, measure different changes, e.g change code inside a function, change the signature of a private property, change the signature of an export variable

[jrieken]

Memory-safe command to run the TypeScript compiler: node --max-old-space-size=4096 ./node_modules/.bin/tsc -p src/tsconfig.json

[jrieken]

@Tyriar There seems to an issue with xterm and its definition files. They appear two times causing these errors

node_modules/xterm-addon-search/typings/xterm-addon-search.d.ts(40,16): error TS2300: Duplicate identifier 'SearchAddon'.
node_modules/xterm-addon-web-links/typings/xterm-addon-web-links.d.ts(13,16): error TS2300: Duplicate identifier 'WebLinksAddon'.
node_modules/xterm/typings/xterm.d.ts(16,15): error TS2300: Duplicate identifier 'FontWeight'.
node_modules/xterm/typings/xterm.d.ts(21,15): error TS2300: Duplicate identifier 'LogLevel'.
node_modules/xterm/typings/xterm.d.ts(26,15): error TS2300: Duplicate identifier 'RendererType'.
node_modules/xterm/typings/xterm.d.ts(351,16): error TS2300: Duplicate identifier 'Terminal'.
src/typings/xterm-addon-search.d.ts(41,15): error TS2300: Duplicate identifier 'SearchAddon'.
src/typings/xterm-addon-web-links.d.ts(52,15): error TS2300: Duplicate identifier 'WebLinksAddon'.
src/typings/xterm.d.ts(16,14): error TS2300: Duplicate identifier 'FontWeight'.
src/typings/xterm.d.ts(21,14): error TS2300: Duplicate identifier 'LogLevel'.
src/typings/xterm.d.ts(26,14): error TS2300: Duplicate identifier 'RendererType'.
src/typings/xterm.d.ts(351,15): error TS2300: Duplicate identifier 'Terminal'.
src/typings/xterm.d.ts(1078,12): error TS2300: Duplicate identifier 'Terminal'.

Removing (or excluding) typings/xterms*.d.ts doesn't seem to be enough as the types seems to mismatch and having only node_modules/xterm/typings/xterm*.d.ts isn't enough.

Can you please take a look and fix. Thanks