Skip to content

Align/cleanup _serviceBrand usage #79918

Closed
@jrieken

Description

@jrieken

We have a convention of using the _serviceBrand-properties on arguments that get injected to constructors. This is to break structural typing and to make sure IInstantiationService#createInstance bubbles back those (non-service) types it needs to be called with.

The _serviceBrand-property is typed as any and different usages patterns have emerged - full text search for _serviceBrand!?: .*?(;|,).

This should be cleaned up like so

  • make the type undefined
  • rename the property to _injectableBrand because this is about types being injected, not necessarily services.

Metadata

Metadata

Assignees

Labels

debtCode quality issues

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions