Opening file with source:line breaks Cmd+D "Add Next Occurance"

[bbugh]

• VSCode Version: 1.37.1
• OS Version: Mac 10.12.6

Issue

Here's a weird one for you! This is 100% reproducible, and only appeared recently.

Whenever I open Visual Studio Code using line numbers (from iTerm2 shortcut or others), the Cmd+D shortcut key to select other instances doesn't work until the VSCode window loses and regains focus.

Does this issue occur when all extensions are disabled?: Yes

Steps to Reproduce:

Part 1

1. Have iTerm2
2. Cmd + Click on a file name
3. Once VSCode opens, Cmd+D on some text that should have another match
4. Notice that the "Selection" menu item at the top flashes as activated, but no new matching selections are selected

Part 2

1. Click around in VSCode, in the same editor, other editors, etc.
2. Press Cmd+D
3. Notice that the "Selection" menu item at the top flashes as activated, but no new matching selections are selected

Part 3

1. Cmd+Tab to another window
2. Cmd+Tab back to VSCode
3. Notice that the Cmd+D key shortcut is now working as expected.

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• cmd+d doesn't work as expected when starting with multiple selections (#43046)

[alexdima]

@bpasero Could we have some bug where we don't know the current focused window at the beginning and then we don't send the command invocation?

Note this gets fixed once focusing out and focusing in ...

Possibly related -- #71553

[bpasero]

@bpasero Could we have some bug where we don't know the current focused window at the beginning and then we don't send the command invocation?

@alexandrudima how can we detect a keypress in the first place if the window is not focused? Are you maybe thinking of macOS where all keys go through the top level menu and not the active window? But this seems to be Windows...

[bbugh]

Hi, I clarified in the first message that it's Mac OS. I originally pasted in the version number but didn't specify that it was Mac, sorry about that.

[bpasero]

Got it, moving to @sbatten who owns menu interactions.

[bbugh]

#71553 does seem possibly related, but opening files from the command line (for me) does not exhibit the behavior I described in the issue. I am able to Cmd+D fine in that scenario.

I tried a couple of other ideas:

• code Gemfile -> Cmd+D works fine
• Cmd+Left Click on the Gemfile -> Cmd+D works fine
• Cmd+Left Click on "Gemfile:97" -> Cmd+D does not work.

It appears to be related to however VSCode is opening files and going to a specific line number.

[alexdima]

@bpasero The menu bar calls IWindowService.sendToFocused -- here it is. Since the menu bar is flashing, it means it is eating up the keybinding so the keybinding does not make it to the renderer and we are relying on vscode:runAction to be sent from the main process to the window...

My guess would be that the IWindowService.sendToFocused is not working sometimes, when launched in very specific ways. I could reproduce #71553 on my mac with #71553 (comment).