Root certificates not loaded on Windows

[chrmarti]

@chrmarti I am running 1.37 but still had to use win-ca.

Originally posted by @kajwanr in microsoft/vscode-azure-account#146 (comment)

[chrmarti]

@bpasero This looks like the minifier bug you hit in #74321. Was there any follow-up on that? (I will test the workaround of avoiding the await triggering it in tomorrow's Insiders.)

[bpasero]

@chrmarti I filed a bug against uglify-js but I think it was never fixed.

[bpasero]

There you go: terser/terser#335

[gjsjohnmurray]

Just a thought. Any way this issue could lie behind the spate of reports we've had about 1.37 user not being able to install extensions unless they change what DNS server they use?

[chrmarti]

This only prevented the loading of root certificates from the OS on Windows (the Node.js baked-in ones were still in use). It should not affect any DNS related issue from what I see.

[chrmarti]

I don't see us using terser-js anymore. We seem to be using uglify-es which hasn't been updated for 1.5 years. Do we have plans for moving to something else @joao?

[chrmarti]

This appears to be fixed in the latest (1.5 years old) version of uglify-es. Not sure if there is a particular reason for staying on an older version. /fyi @jrieken