Code lens can sometimes overlap with code

[eamodio]

Issue Type: Bug

I have only seen this with today's insiders (1.34), but sometimes the code lens overlaps with the editor content. See below:

VS Code version: Code - Insiders 1.34.0-insider (e88a32f, 2019-04-04T19:48:00.957Z)
OS version: Windows_NT x64 10.0.18362

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	undefined
Memory (System)	31.93GB (16.20GB free)
Process Argv
Screen Reader	no
VM	0%

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Add weight/priority to code lens providers (#28166)
• Alternative to double-click to close code lens (#60210)

[jrieken]

😱 what... @eamodio when you see this can you use the Element dev tool to inspect the html structure? Look for codelens-decoration and monaco-visible-content-widget classes

[eamodio]

The DOM of both good and bad code lens look identical -- and it looks like they are positioned appropriately, but the issue is that for some reason there is a missing view zone -- notice that there is no 2 view zone

Bad code lens:

Good code lens:

I think that this issue might be in some way related to #71707 since it feels like it only happens after a on-save format. Also switching to a different tab and back fixes it.

[jrieken]

This just happened to me with Insiders (without fix for #71707) and it seems that one view zone is missing. Below screen shot shows how 13 isn't there...

[eamodio]

I don't know what changed, but I'm seeing this issue happen A LOT more frequently. And I get tripped up, because sometimes it overlaps with a blank line, and it makes me think I'm missing a blank line in that space, causing me to add a new line and only then realize that there was one, it was just this issue.

[jrieken]

Nobody here having repro steps, right? Looking at code lens source this should only happens with an error somewhere - the calls to add and remove the viewzone/content widget pair always come together. One failing could prevent that other but it should surface as error...