Tree filtering breaks atom-keybindings

[Ky6uk]

Issue Type: Bug

Last update just broke my workflow with files tree. I tried to use workbench.list.keyboardNavigation="simple" as it was reffered here but it still broken. In simple mode pressing A does trigger the filter and focusing first file with name beginning on the A letter and in the same time it triggers new file creation on the same level with the highlighted file.

So it produces some problems

1. Focusing on the opened file lost and jumped to the first found file.
2. After that the input for filename of the newly created file placed in wrong position, near this focused file.

VS Code version: Code 1.31.0 (7c66f58, 2019-02-05T22:32:14.164Z)
OS version: Darwin x64 18.2.0

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-4250U CPU @ 1.30GHz (4 x 1300)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: enabled rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	2, 2, 2
Memory (System)	8.00GB (0.98GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (23)

Extension	Author (truncated)	Version
better-comments	aar	2.0.3
Bookmarks	ale	10.2.2
project-manager	ale	10.3.2
vscode-color	ans	0.4.5
snapshot-tools	asv	0.2.2
vscode-svgviewer	css	1.4.7
vscode-eslint	dba	1.8.0
EditorConfig	Edi	0.12.8
vscode-npm-script	eg2	0.3.5
vscode-pull-request-github	Git	0.3.2
beautify	Hoo	1.4.8
vscode-styled-components	jpo	0.0.25
typescript-duck-snippet	Ky6	1.0.0
zero-reference	Ky6	1.1.0
atom-keybindings	ms-	3.0.5
vscode-typescript-tslint-plugin	ms-	0.4.1
debugger-for-chrome	msj	4.11.1
vscode-versionlens	pfl	0.22.0
vscode-icons	rob	8.1.0
code-settings-sync	Sha	3.2.4
stylelint	shi	0.48.0
gitblame	wad	2.6.3
vscode-proto3	zxh	0.2.2

(1 theme extensions excluded)

References

• New Explorer: Keyboard shortcut for New File ('A') no longer creates a new file but activates Filter #68030
• Cannot create file/folder #68085

[joaomoreno]

in the same time it triggers new file creation on the same level with the highlighted file

Did you assign A to create a new file?

[Ky6uk]

@joaomoreno I'm not, but it can be done by other extension like atom-keybindings. I'm not sure because I'm using it for years. So is it possible to bring back keyboardNavigation behaviour for files tree, or disable it completely or some other workaround (without changes of my current keybindings)?

[Ky6uk]

I also did read changelog more closely. So as I understand it can be done by setting listAutomaticKeyboardNavigation to false by any extension. Isn't it? Or can I change listAutomaticKeyboardNavigation manually by settings?

[joaomoreno]

As a user, you cannot change it. But we can certainly let the atom-keybindings guys know, just as we did with VIM: VSCodeVim/Vim#3432 and every atom-keybindings user would have to press a keybinding to go into that mode. What do you think?

[Ky6uk]

@joaomoreno I did create a PR for this. But for some reasons it's not working for me. Maybe I forgot about something.

Also I can say an user should be able to disable this behaviour I think. Because nothing to stop the user to assign single key as a hotkey of explorer.newFile command for example.

Another way is filtration should not be started if first pressed key is a hotkey for this panel.

[joaomoreno]

Because nothing to stop the user to assign single key as a hotkey of explorer.newFile command for example.

That's correct. But so far users have assigned simple letter keybindings in lists simply because they were no-ops so far. It's true that they might already have them assigned today, but I'm pretty sure they are easily convinced to simply add a modified key to they keybinding in order to benefit from this feature.

[joaomoreno]

@Ky6uk OK Got your PR to atom-keybindings merged after a small fix, found why it wasn't working: microsoft/vscode-atom-keybindings@b1e3f33

Thanks for all the help, a new extension version should be coming out any time now!