Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List references: transition from history to results is not smooth #67966

Open
bpasero opened this issue Feb 6, 2019 · 4 comments
Open

List references: transition from history to results is not smooth #67966

bpasero opened this issue Feb 6, 2019 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug references-viewlet tree-views Extension tree view issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Feb 6, 2019

Steps to Reproduce:

  1. have a history of references
  2. find references again

=> 🐛 the transition from history to results is not very smooth, in the video you can see how the history partially still shows after running "Find References"

before

@jrieken jrieken added polish Cleanup and polish issue references-viewlet labels Feb 6, 2019
@jrieken jrieken added this to the February 2019 milestone Feb 6, 2019
@jrieken
Copy link
Member

jrieken commented Feb 8, 2019

@sandy081 This is really cumbersome to implement with the tree. I think the message should be provided by the data source so that the "manual" sync step for extensions becomes obsolete. Then, I don't know of a good way to clear and populate the tree without it feeling sluggish...

@sandy081 sandy081 added the tree-views Extension tree view issues label Feb 12, 2019
@sandy081
Copy link
Member

Does it looks like a need for clear API that clears everything?

@sandy081
Copy link
Member

I group refresh calls now by waiting for some time. This could be causing the delay between message and refresh calls. May be I would try to group updating message and refreshes together and see how it behaves.

@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Feb 13, 2019
@sandy081 sandy081 modified the milestones: February 2019, March 2019 Feb 25, 2019
@jrieken
Copy link
Member

jrieken commented Mar 25, 2019

@sandy081 This is still pretty bad. I need the tree to refresh without showing the old nodes

@sandy081 sandy081 modified the milestones: March 2019, April 2019 Mar 26, 2019
@sandy081 sandy081 removed the polish Cleanup and polish issue label Mar 26, 2019
@sandy081 sandy081 modified the milestones: April 2019, May 2019 Apr 29, 2019
@sandy081 sandy081 modified the milestones: May 2019, On Deck May 24, 2019
@alexr00 alexr00 assigned alexr00 and unassigned sandy081 Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug references-viewlet tree-views Extension tree view issues
Projects
None yet
Development

No branches or pull requests

4 participants