git.promptToSaveFilesBeforeCommit should not warn on unstaged files.

[maslade]

Issue Type: Feature Request

This new feature is over-eager and triggers on unsaved files that are not part of the commit, which I don't think makes sense. If I have staged file A.js and am committing only file A.js, I should not receive a warning that B.js is unsaved. Ideally it will only consider staged files unless I am committing all staged and unstaged.

VS Code version: Code 1.30.2 (61122f8, 2019-01-07T22:54:13.295Z)
OS version: Windows_NT x64 10.0.17763

[flurmbo]

Hi, can I work on this one?

[joaomoreno]

@flurmbo Sure!

[rkeithhill]

I'm not in favor of changing this. Or if it is changed, perhaps give finer grain control over when it prompts. I always want a prompt because I'm a bit lazy and usually let VSCode add the files to staging for me when I commit.

[maslade]

@rkeithhill I see the value in your use case, but I don't think it makes sense in this feature. If you committed with a file that was untracked but saved this warning wouldn't help you. I think it would make more sense as a separate feature that warns on commit if there are untracked files regardless of save state.