Unable to attach to lsp server when debugging extension

[eamodio]

Issue Type: Bug

This started relatively recently and only affects the insiders builds, but I can no longer attach to my lsp server when debugging my extension. When I try the attach just times out. If I switch back to the stable build (1.29.1) everything works fine.

Unfortunately the project is currently closed-source, so I can't provide a good reproducible case. Let me know if I can provide any other details.

/cc @isidorn

VS Code version: Code - Insiders 1.30.0-insider (456e8e6, 2018-11-26T11:05:14.406Z)
OS version: Windows_NT x64 10.0.18282

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-6700K CPU @ 4.00GHz (8 x 4008)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled video_decode: enabled video_encode: enabled webgl: enabled webgl2: enabled
Memory (System)	31.93GB (16.64GB free)
Process Argv
Screen Reader	no
VM	0%

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• NEW Debugging extension & lsp server issues (#60809)

[isidorn]

Assigning first to @weinand and @roblourens to investigate why the attach times out

[roblourens]

Most likely the lsp server did not start in debug mode. Can you get anything if you open localhost:6009 in a browser?

[eamodio]

Hrm, I don't think that is the case. This is the same workflow as I've been using for months and using exactly the same code and setup prior to a week or so ago this all worked fine. Also if I switch to the 1.29.1 running against the exact same workspace, build, etc it all works fine.

[roblourens]

I can't repro it with https://github.com/Microsoft/vscode-extension-samples/tree/master/lsp-sample, can you? Can't think of anything that changed on my end.

[eamodio]

I can repro with that repo too. Here is what I see in the Debug Output:

Again this works fine in 1.29.1. I am also on Windows 10

[eamodio]

This is what I see in the browser with 1.30

With 1.29.1 I get

[roblourens]

You're sure your extension is being activated? Can you tell that the server process actually started? Can you find it in Task Manager and verify that its command line args contain the debug attribute?

[eamodio]

Yup it definitely works and is loaded

Will check the command line in a few

[roblourens]

@dbaeumer any ideas here?

[eamodio]

Here's using 1.30 (fails)

Here's using 1.29.1 (works)

[dbaeumer]

@roblourens no, not really since it works with 1.29.1 @eamodio can you connect using chrome ?