Show debug sessions under a new split view section

[isidorn]

Similar to how git shows mulitple git repositories, debug could show multiple debug sessions in a new split view section which we would be first in the debug viewlet.
In case we choose to do this we would no longer show multiple sessions in the callstack view but only the focused one.
This new section would only show up if a user has multiple sessions running.

Pros: easy and clear to change active session (also if your debug toolbar is docked), consistent with git
Cons: eats up vertical space

This idea was proposed by @bpasero
fyi @roblourens @weinand @auchenberg

[weinand]

Does not scale well.
Example: cluster debugging.
Number of sessions is inherently dynamic as opposed to a static number of git repositories.

Another important drawback is that only a single callstack is visible. This makes it harder to debug the interaction between a client and a server (for example).

[auchenberg]

I'm having a hard time visualizing this. In an ideal world we would be able to "mix" stack frames come multiple debugging targets into a unified view. Imagine debugging a front-end + back-end and being able to see the flow across the stacks in the right order.

[isidorn]

@auchenberg to visualise use git in multi root workspace
No we would not mix stack fames, whatever is focused in the top view would be shown in the bottom

I agree with the second drawback @weinand pointed out
As for scaling it equally scales as the current soltuion

[bpasero]

Git repositories can come and go as well depending on external (out of workspace) files opened. I suggest to mock this up an run through it to see if it would work with the other views.

[roblourens]

I like being able to see multiple callstacks at once. At least, I should be able to see the state of the other sessions (at breakpoint or not). If there was some indicator of that state, I might be ok with it.

But I also agree with @weinand that debug sessions are much more dynamic and I might expect to use more of them simultaneously.

[weinand]

There is no value in mocking this if we cannot see multiple callstacks at once.

[bpasero]

@roblourens @weinand see, I was never suggesting to filter the call stack like that. For that reason let's do a mockup so that you understand our idea. I think a textual description of the UX flow will only confuse you.

[isidorn]

@misolori what tool are you using for mockups? Would you have cycles to mock this up - I can also look into mocking it up if the tool is user friendly :)

[weinand]

This is the Cluster scenario I'm interested in:

https://code.visualstudio.com/assets/docs/nodejs/nodejs-debugging/auto-attach-cluster.gif

[miguelsolorio]

@isidorn I'm using Figma (I can add you to our account). I've got a few things pre-built for the debugger that can help jump start this. If you can provide a quick sketch/whiteboard that'll help clarify the layout.

[miguelsolorio]

@isidorn I did a quick attempt at this (based off what I could understand). Is this what you're looking for?

[isidorn]

@misolori thanks a lot, how I understood @bpasero is something like that, but he can comment more.
The only difference that I know is that the Threads (in your example Node 49283) should still be displayed in the call stack view, and the session would be a flat list of sessions (not a tree). With some session specific actions on top.

Also thanks for adding me to Figma, I'll check it out