Allow to edit the left hand side of a diff editor if possible

[joaomoreno]

You can hit it by using Compare with action and --diff. This is really sad. The editor on the left should only be read-only if the input behind it is really read-only (coming from the git index, for example).

cc @alexandrudima @bpasero

[bpasero]

Yes I always wanted that actually :)

[alexdima]

On my side it would be pretty easy to just comment out the forcing of readOnly=true on the left-hand-side. But I need to add an option to allow the workbench to make the git diff case left-hand-side readOnly.

[alexdima]

There's also the inline diff case, where I cannot make the "original" editable.

[bpasero]

@alexandrudima yeah I think we know in all places if the left hand side should be editable or not, I think it would only be the file-2-file compare where this applies.

[alexdima]

Ok, there is a new option originalEditable to the diff editor. It is false by default.

[bpasero]

@alexandrudima cool, let me pick this up then...

[bpasero]

@alexandrudima so by default this option is true or false?

[alexdima]

:) Wrote in comment and in jsdoc: it is false by default.

[bpasero]

👍