Skip to content

filters.ts' matchesSubString() performs badly in some cases #35346

Closed
@chrmarti

Description

@chrmarti

E.g., matchesSubString('aaaaaaaaaaaax', 'aaaaaaaaaaaaaaaaaaaaaaaaa') calls _matchesSubString() 38 million times due to the backtracking being done.

This is used for the fuzzy highlighting in QuickOpen. It seems to have been there for some time, not a recent regression.

/fyi @bpasero

Metadata

Metadata

Assignees

Labels

bugIssue identified by VS Code Team member as probable bugfreeze-slow-crash-leakVS Code crashing, performance, freeze and memory leak issuessearchSearch widget and operation issuesverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions