Skip to content

Provide way for a language to re-enable editor.quickSuggestions inside of a string or comment #34857

Closed
@mjbvz

Description

@mjbvz

Problem
Many languages allow embedding language fragments inside of strings. In JavaScript for example:

`Max int: ${Number.MAX_SAFE_INTEGER}`

While typing within the ${...} however, we do not show quick suggestions. The root cause is that the template expression is within a string, and the editor.quickSuggestion.strings setting explicitly disable quick suggestions within strings.

Proposal
We now have a convention of marking languages embedded within strings with the meta.embeded scope. This could be used to reset the quick suggestions scopes.

Here's the scope of the above code:

screen shot 2017-09-22 at 2 35 25 pm

In this stack, we'd first see string.template which would disable quick suggestions. Then, further up the stack, we see meta.embedded which would reset the quick suggestion mode.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions