debugger doesnt stop when exiting extension development host

[chrisdias]

git clone https://github.com/microsoft/vscode-docker
cd vscode-docker && npm install
code-insiders .

F5 to launch the debugger
extension development host starts up
close the extension development host)

results:

• the debugger is still running, i have to press stop to actually stop the debugger
• pressing restart hangs with following message:

[weinand]

@bpasero I've debugged this on the debugger side and it seems that closing the EH window does neither terminate the EH node process nor does it send any broadcast events for this.

[bpasero]

@weinand this seems to be a regression from us moving to --inspect, I cannot reproduce the hanging extension host when I do not pass over the --inspect-brk to the extension host on launch.

Could it be that the debugger needs to explicitly send some signal to the debuggee to signal the session is over and otherwise the process will never terminate?

[bpasero]

/cc @alexandrudima because I know he refactored a lot of the extension host process recently to support restarting. I am not sure if there was any impact on how the process shutsdown (e.g. I see a newly introduced _cleanResources that seems to kill the extension host process on shutdown.

[weinand]

@bpasero yes, a terminate request from the debugger might be necessary.
@roblourens do you know something about this?

The problem is that the debugger doesn't know when the EH window's close button has been pressed. So we would at least need another broadcast event for this.