-
Notifications
You must be signed in to change notification settings - Fork 34.1k
Closed
Labels
feature-requestRequest for new features or functionalityRequest for new features or functionalityjavascriptJavaScript support issuesJavaScript support issuesupstreamIssue identified as 'upstream' component related (exists outside of VS Code)Issue identified as 'upstream' component related (exists outside of VS Code)verification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded
Milestone
Description
- VSCode Version: 1.14.0-insider
- OS Version: Windows 10 OS Build 15063.296
Steps to Reproduce:
- Create a new file
test.js
with below content
$().bind();
Notice that the link is
https://api.jquery.com/bind/#bind-eventType-eventData-handler}
There is an extra }
at the end of the link.
When you click on this link, the browser will also go to this incorrect link.
- Open Developer Tools, you will find the the source code:
<a href="#" data-href="https://api.jquery.com/bind/#bind-eventType-eventData-handler}" title="https://api.jquery.com/bind/#bind-eventType-eventData-handler}">https://api.jquery.com/bind/#bind-eventType-eventData-handler}</a>
BTW, The definition of function bind is:
/**
* Attach a handler to an event for the elements.
*
* @param eventType A string containing one or more DOM event types, such as "click" or "submit," or custom event names.
* @param eventData An object containing data that will be passed to the event handler.
* @param handler A function to execute each time the event is triggered.
* @see {@link https://api.jquery.com/bind/#bind-eventType-eventData-handler}
*/
bind(eventType: string, eventData: any, handler: (eventObject: JQueryEventObject) => any): JQuery;
My guess is that the bug might exist here, but I'm not sure.
https://github.com/Microsoft/vscode/blob/master/src/vs/base/browser/htmlContentRenderer.ts#L130-L141
Metadata
Metadata
Assignees
Labels
feature-requestRequest for new features or functionalityRequest for new features or functionalityjavascriptJavaScript support issuesJavaScript support issuesupstreamIssue identified as 'upstream' component related (exists outside of VS Code)Issue identified as 'upstream' component related (exists outside of VS Code)verification-neededVerification of issue is requestedVerification of issue is requestedverifiedVerification succeededVerification succeeded