New "Keyboard Shortcut" dialog should display current assignment

[NCC1701M]

• VSCode Version: 1.11.1
• OS Version: Windows 7 [6.1.7601]

Steps to Reproduce:

1. Go to File -> Preferences ->Keyboard Shortcuts
2. Select a keybinding
3. Klick on + to add a new keybinding
4. Press desired key combination

Current behaviour

The dialog only shows the pressed key combination again.

Expected behaviour

The dialog should display if the combination is already bind to a command and if so to which command.

For example:

or

[sandy081]

Nice idea

[brandontruggles]

I would like to work on this!

[sandy081]

@brandonrninefive That's great. Let me know if you need any help.

[brandontruggles]

Hey @sandy081 , I'd like to ask for some direction for adding this feature.

Currently, I've been looking at the following method to start: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/preferences/browser/keybindingWidgets.ts#L200

As well as this method:
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/preferences/browser/keybindingWidgets.ts#L227

Two main questions I have:

1. Which would be the better method to use to place these changes? For example, should this be a label that displays in place of the printed key binding using the same DOM node in the event that the binding is already taken, or should it have its own DOM node underneath? If a new DOM node needs to be created, please fill me in on how to account for translation properly (which I'm guessing is handled by nls.localize()).

2. Can you point me to which variable I should be using to access the list of existing keybindings from the appropriate function in order to run my check?

Thank you!

[sandy081]

@brandonrninefive I would show the label <number> conflicts as follows.

This has to be a new DOM element and the label should come from outside. It means, DefineKeybindingWidget should have an API to set the label from outside and also an event when keys are entered. KeybindingsEditor listens to the event and updates the label by checking if the keybindings has conflicts or not.

When no conflicts, label can be empty

[brandontruggles]

Thank you for your help @sandy081 , I got it working and submitted the changes in PR #40405. Assuming that everything goes well with that PR, I have another suggestion for this feature. Could we perhaps make the conflict label a link, which will close the dialogue and search for the entered key combination in the keybindings list? This way, users can see what the particular conflicts are, rather than just how many there are. Please let me know your thoughts :).