ftp-simple, ftp-sync doesn't work since update 1.93.0

[naja-ep]

Type: Bug

Hello.
Since updeted 1.93.0 version, ftp-simple, ftp-sync doesn't work.
(related with "ftp" things extension)

and also code.visualstudio.com, website doesn't work.

VS Code version: Code 1.93.0 (4849ca9, 2024-09-04T13:02:38.431Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item	Value
CPUs	AMD Ryzen 5 5500U with Radeon Graphics (12 x 2096)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_graphite: disabled_off video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled webnn: disabled_off
Load (avg)	undefined
Memory (System)	9.86GB (1.92GB free)
Process Argv	--crash-reporter-id 593b9d69-9247-46dd-9a05-78e1945ee036
Screen Reader	no
VM	0%

Extensions (11)

Extension	Author (truncated)	Version
increment-selection	alb	0.2.0
vscode-eslint	dba	3.0.10
prettier-vscode	esb	11.0.0
fontsize-shortcuts	fos	1.5.0
beautify	Hoo	1.5.0
ftp-sync	luk	0.3.9
git-graph	mhu	1.30.0
vscode-language-pack-ko	MS-	1.93.2024090409
material-icon-theme	PKi	5.10.0
LiveServer	rit	5.7.9
px-to-rem	sai	1.3.1

(1 theme extensions excluded)

A/B Experiments

vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256860
vscod805cf:30301675
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonnoceb:30805159
asynctok:30898717
pythonmypyd1:30879173
2e7ec940:31000449
pythontbext0:30879054
accentitlementst:30995554
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
g316j359:31013175
a69g1124:31058053
dvdeprecation:31068756
dwnewjupyter:31046869
2f103344:31071589
impr_priority:31102340
nativerepl1:31104043
refactort:31108082
pythonrstrctxt:31112756
wkspc-onlycs-t:31132770
wkspc-ranged-t:31125599
fje88620:31121564

[gjsjohnmurray]

Have you yet reported this to the extension author?

I recommend giving more detail than "doesn't work".

[naja-ep]

I re-downloaded version 1.92.x of vscode. Then I run ftp-simple again and it works. The author of the extension was not notified. However, there seems to have been a conflict between the vscode version upgrade and the extension. 2024년 9월 6일 (금) 오후 3:11, John Murray ***@***.***>님이 작성:

…

Have you yet reported this to the extension author? I recommend giving more detail than "doesn't work". — Reply to this email directly, view it on GitHub <#227743 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AQ7T4E4AAI54WH2UHCZUYL3ZVFBQRAVCNFSM6AAAAABNXZG2GGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZTGMYTMOJXGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- ===================================================== (주)이파트 디자인팀 나진아 E-mail : naja@ <http://goog_1466286384>epart.com ***@***.***> 대표번호 : 02-545-3800 주소 : (06192) 서울시 강남구 선릉로 428, 위워크 9층 =====================================================

[TylerLeonhardt]

This seems to have happened somewhere in these commits:
92feede...b60fe00

I went through each of them and am fairly confident that it was due to our Electron bump (and maybe Node.js was bumped in the process). Passing over to @deepak1556 .

The repro is easy:

• Install https://marketplace.visualstudio.com/items?itemName=humy2833.ftp-simple
• Run ftp-simple : Config - FTP connection setting in the Command Palette
• It errors: Command 'ftp-simple : Config - FTP connection setting' resulted in an error Cannot read properties of undefined (reading '0')

The code for the command is here:

https://github.com/humy2833/FTP-Simple/blob/master/extension.js#L182-L191

[Codingale]

Someone has raised an issue (linked below), but seeing as the last commit was 3 years ago, I'm assuming the plugin won't be updated, is it possible this is a regression and not just, well abandoned? I see in the stack trace it calls showFlaggedDeprecation so uh, doesn't look good.

Hopefully this is easily fixed, I use SFTP file editing near constantly and would have to probably go back to Notepad++.. would save RAM I guess.
humy2833/FTP-Simple#324 (comment)

[yunusga]

humy2833/FTP-Simple#324 (comment) ftp-simple hotfix

[deepak1556]

We had a node.js version bump in v1.93 and from the range nodejs/node@v20.14.0...v20.15.1 it is very likely the extension needs to adopt for nodejs/node@033f985

Sorry this is something that needs to be addressed in the extension, closing as wontfix.