Integrated terminal (cygwin64 bash) not rendering color escape codes on php output

[hazzlewis]

• VSCode Version: 1.10.2
• OS Version: Windows 10.0.14393 Build 14393

Using cygwin64 bash.exe as integrated terminal like so:

Standard color prompt works just fine:

However executing a PHP script, color escape codes are not interpreted properly, resulting in garbled output. Specifically, running Laravel's artisan command:

This same command works as expected in mintty:

Am i doing anything wrong or is this a bug?

[Tyriar]

Looks like \x1b is being translated to ? somewhere along the way.

[Tyriar]

@hazzlewis is there any trick to getting the cygwin exe running in the terminal? It's telling me /usr/bin/bash wasn't found after a fresh install and using your settings?

[hazzlewis]

You may have to re-run the setup installer and install the CHERE package. Not sure if needed but thats the only thing i can think of which i have installed which could make a difference off the top of my head. Kind Regards Harry Lewis

…

-------- Original message -------- From: Daniel Imms <notifications@github.com> Date: 14/03/2017 22:31 (GMT+00:00) To: Microsoft/vscode <vscode@noreply.github.com> Cc: Harry Lewis <Harry.Lewis@paragon.net.uk>, Mention <mention@noreply.github.com> Subject: Re: [Microsoft/vscode] Integrated terminal (cygwin64 bash) not rendering color escape codes on php output (#22616) @hazzlewis<https://github.com/hazzlewis> is there any trick to getting the cygwin exe running in the terminal? It's telling me /usr/bin/bash wasn't found after a fresh install and using your settings? - You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#22616 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ATSpMbDeg8AgYSIoHmw0T2vYcvGLdOUAks5rlxU6gaJpZM4McwqL>.

[hazzlewis]

Interestingly, it works absolutely fine when executing the command on a VM. Apparently the issue is only occurring when executing it locally. Maybe it's something to do with Windows vs Linux.

Local:

harry@Harrys-Laptop /cygdrive/c/Users/harry/vc/pub (master)
$ php -v
PHP 7.1.1 (cli) (built: Jan 18 2017 18:51:14) ( ZTS MSVC14 (Visual C++ 2015) x86 )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
    with Xdebug v2.5.0, Copyright (c) 2002-2016, by Derick Rethans

VM:

vagrant@vagrant:~$ php -v
PHP 7.0.15-0ubuntu0.16.04.1 (cli) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2017 Zend Technologies
    with Zend OPcache v7.0.15-0ubuntu0.16.04.1, Copyright (c) 1999-2017, by Zend Technologies

[Tyriar]

@hazzlewis a lot more stuff happens to get the terminal working on Windows so that's not surprising. Do you see the same problem if run through Git Bash? (install git and then add "terminal.integrated.shell.windows": "C:\\Program Files\\Git\\bin\\bash.exe")

[hazzlewis]

Yup, same dice... 👎 :(

[Tyriar]

Ping @rprichard, potential issue with winpty (or the PHP cli?).

[rprichard]

Looks like \x1b is being translated to ? somewhere along the way.

winpty translates 'x1b' to '?', but that's expected (rprichard/winpty#47).

It's probably an incorrect environment setting. I see that the issue reproduces if TERM is set to xterm. That shouldn't happen -- VSCode should leave TERM unset, then Cygwin bash.exe should set it to cygwin.

[hazzlewis]

Do you need more info about my environment? Kind Regards Harry Lewis

…

-------- Original message -------- From: Ryan Prichard <notifications@github.com> Date: 22/03/2017 02:35 (GMT+00:00) To: Microsoft/vscode <vscode@noreply.github.com> Cc: Harry Lewis <Harry.Lewis@paragon.net.uk>, Mention <mention@noreply.github.com> Subject: Re: [Microsoft/vscode] Integrated terminal (cygwin64 bash) not rendering color escape codes on php output (#22616) Looks like \x1b is being translated to ? somewhere along the way. winpty translates 'x1b' to '?', but that's expected (rprichard/winpty#47<rprichard/winpty#47>). It's probably an incorrect environment setting. I see that the issue reproduces if TERM is set to xterm. That shouldn't happen -- VSCode should leave TERM unset, then Cygwin bash.exe should set it to cygwin. - You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#22616 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ATSpMSKMcKY4Y4VS_nrKbhFv2shG_sVKks5roIkNgaJpZM4McwqL>.

[rprichard]

@hazzlewis Yes, I'm only able to reproduce the issue by manually setting TERM incorrectly, so I need more info. e.g. What is your TERM variable set to?