Skip to content

Render Whitespace: spaces are hard to see with dark theme #223392

Open

Description

Whitespace characters are rendered subtly, understandably, using gray. Space characters are shown as small gray disks. With my glasses, my monitor at its default resolution and the default zoom level, I find it hard to notice them with the dark theme, in particular when they are trailing. If I know where they are, they are not hard to see, but if I don't, they are far from obvious:
image

I would argue this is somewhat of a bug since I perceive the contrast as greater in the normal mode than in dark mode:
image

In my opinion, the perceived contrast is considerably lower in dark mode.

  1. Open a file with spaces
  2. Enable the Render Whitespace setting (editor.action.toggleRenderWhitespace)
  3. Switch to the dark theme (workbench.action.toggleLightDarkThemes)
  4. Evaluate how much time you need to identify all lines with trailing whitespace (and compare with the time needed in normal mode)

VS Code version: Code 1.91.1 (f1e16e1, 2024-07-09T22:06:49.809Z)
OS version: Windows_NT x64 10.0.19045

System Info
Item Value
CPUs 12th Gen Intel(R) Core(TM) i7-12850HX (24 x 2419)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled
Load (avg) undefined
Memory (System) 63.69GB (37.04GB free)
Process Argv --file-uri vscode-remote://attached-container%2B7b22636f6e7461696e65724e616d65223a222f6465762d766d2d7361672d6f732d31227d/home/user/repos/sqin-outils-dev/sqin.code-workspace
Screen Reader no
VM 0%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Labels

editor-coreEditor basic functionalitythemesColor theme issues

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions