Skip to content

Normalize let/const exports in vscode.d.ts #216555

Description

Some properties in extension API like

export let activeTextEditor: TextEditor | undefined;
are exported with let because they can change, but this also implies that extensions can set them. That isn't allowed, only vscode can change them. Some similar properties already use const. We should normalize these to const everywhere to avoid confusion.

readonly communicates the intent a little better, but this is a namespace, not properties on an interface. But I think it's clear from the name and behavior that these properties will change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions