Conditional breakpoints need to better report stale references

[BobFrankston]

Type: Bug

When I started my program I was getting an error about an invalid variable. The error was obscure until I figure out the problem was that I had changed the name of a variable but a conditional breakpoint was using the old name.

The simple fix is to provide an explicit messaging saying that was the problem rather than a long stake trace with a strange message about a variable not being found.

VS Code version: Code 1.83.0 (e7e0370, 2023-10-03T16:12:16.321Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-10710U CPU @ 1.10GHz (12 x 1608)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	undefined
Memory (System)	63.80GB (42.75GB free)
Process Argv	backts.code-workspace --crash-reporter-id c3821d8c-1dd2-4bbf-843a-9db0c8d0bbbf
Screen Reader	no
VM	0%

Extensions (75)

Extension	Author (truncated)	Version
Bookmarks	ale	13.4.2
vscode-sqlite	ale	0.14.1
shaderlabvscodefree	aml	1.3.3
vscode-run-workspace-tasks	asv	1.0.1
spellright	ban	3.0.118
csharp-extentions-pack	bou	0.3.0
vscode-toggle-quotes	Bri	0.3.6
insert-unicode	bru	0.15.1
xml2json	bui	1.2.5
npm-intellisense	chr	1.4.4
vscode-mysql-client2	cwe	6.7.4
dendron-paste-image	den	1.1.1
vscode-deno	den	3.25.1
snippet	dev	1.1.0
docs-markdown	doc	1.0.3
xml	Dot	2.5.1
gitlens	eam	14.3.0
kotlin-formatter	esa	0.0.6
vs-code-xml-format	fab	0.1.5
kotlin	fwc	0.2.32
copilot	Git	1.123.0
copilot-chat	Git	0.8.0
remotehub	Git	0.62.0
debug-visualizer	hed	2.4.0
vscode-drawio	hed	1.6.6
nbpreviewer	jit	1.2.2
pwa-tools	joh	0.1.0
vscode-peacock	joh	4.2.2
vscode-csharp-snippets	jor	1.1.0
theme-by-language	jsa	1.2.1
vscode-icon-theme	jtl	1.6.6
unity-code-snippets	kle	2.2.5
adb-filesystem	Mak	0.0.3
code-groovy	mar	0.1.2
Kotlin	mat	1.7.1
code-beautifier	mic	2.3.3
prettify-json	moh	0.0.3
mongodb-vscode	mon	1.2.1
csdevkit	ms-	0.5.150
csharp	ms-	2.5.30
vscode-dotnet-runtime	ms-	1.8.0
vscodeintellicode-csharp	ms-	0.1.26
vscode-edge-devtools	ms-	2.1.3
isort	ms-	2023.10.1
python	ms-	2023.18.0
remote-containers	ms-	0.315.1
remote-ssh	ms-	0.106.5
remote-ssh-edit	ms-	0.86.0
remote-wsl	ms-	0.81.7
azure-repos	ms-	0.38.0
cpptools	ms-	1.17.5
live-server	ms-	0.4.11
powershell	ms-	2023.6.0
remote-explorer	ms-	0.4.1
remote-repositories	ms-	0.40.0
vs-keybindings	ms-	0.2.1
vsliveshare	ms-	1.0.5883
material-icon-theme	PKi	4.31.0
pwa-studio	PWA	1.3.4
quicktype	qui	12.0.46
vscode-rapidapi-client	Rap	1.10.2
vscode-services	rap	1.0.2
LiveServer	rit	5.7.9
vsc-nwjs	rua	1.0.18
markdown-preview-enhanced	shd	0.8.1
shelly-vscode-extension	She	0.0.2
shader	sle	1.1.5
unique-window-colors	stu	1.0.51
pdf	tom	1.2.2
luna-paint	Tyr	0.16.0
adb-interface-vscode	vin	0.22.4
vscode-icons	vsc	12.5.0
quokka-vscode	Wal	1.0.569
vscode-todo-highlight	way	1.0.5
markdown-all-in-one	yzh	3.5.1

A/B Experiments

vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263cf:30335440
vscorecescf:30445987
vscod805cf:30301675
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30410667
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
3biah626:30602489
89544117:30613380
a9j8j154:30646983
showlangstatbar:30737416
03d35959:30757346
ecj1e332:30736112
pythonfmttext:30731395
fixshowwlkth:30771522
showindicator:30805244
pythongtdpath:30769146
i26e3531:30792625
pythonnosmt12:30797651
pythonidxpt:30805730
pythonnoceb:30805159
copilotsettingc:30839828
dsvsc013:30795093
dsvsc014:30804076
diffeditorv1:30821571
dsvsc015:30845448

[roblourens]

What language? What error? Please explain more

[BobFrankston]

Sorry, I've been so heads down in TypeScript I forgot to mention it, though it's really JavaScript.

I had a condition breakpoint and then deleted the variable it was referencing, but I didn't notice the conditional breakpoint was there. The error message was very confusing since it treated it as happening in a line of code rather than mentioning the breakpoint.

Ideally, the fix is to just mention that the problem is in the conditional breakpoint.

[roblourens]

If I enable breaking on "caught exceptions" and have an error in a conditional breakpoint expression, then I break on something like this

and clicking the frame doesn't open any editor, so it's a little confusing @connor4312 . I don't see the error message you describe but you could have something else that ends up logging it.

[roblourens]

vscode-debugadapter-e145a833.json.gz