option to create non-existent file not shown when markdown-preview-editor enabled as default

[mtill]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.80.1
• OS Version: Ubuntu Linux 22.04

Hello,
in a markdown document, when clicking a link to a non-existent markdown document, usually, VS code asks whether this new file should be created. However, this does not work when assigning the preview-editor as default.

Steps to Reproduce:

1. configure VS code to open markdown documents with preview editor:
   "workbench.editorAssociations": {
   "*.md": "vscode.markdown.preview.editor"
   }
2. open a markdown document and create a link to a non-existent file:
   
3. click the link. An error message is thrown:
   

Expected behavior: Instead of throwing an error message, VS Code should ask the user whether the non-existent file should be created. This is the default behavior when vscode.markdown.preview.editor has not been configured for opening *.md files.

Thank you very much for your help
Kind regards
Deb

[Kalmaegi]

It appears to be due to different handling of errors by textEditor and webviewEditor

Hello, I'd like to try working on this if available. I'll update with progress.

Update: So I have the prompt changed and it will now create the file. I am having a little bit of trouble getting it to load the file after creating it however. If anyone more familiar with the codebase could point me in the right direction I'd appreciate it. The file I'm looking at is: src/vs/workbench/services/textfile/common/textFileEditorModel.ts. Thanks!

Update: So I have the prompt changed and it will now create the file. I am having a little bit of trouble getting it to load the file after creating it however. If anyone more familiar with the codebase could point me in the right direction I'd appreciate it. The file I'm looking at is: src/vs/workbench/services/textfile/common/textFileEditorModel.ts. Thanks!

Hey just wanted to follow up on this, @mjbvz do you have any suggestions on how I could solve this?

[mtill]

Hi,
thank you very much for your effort!
Unfortunately, I can't be of much help here, however, I'd like to have a look on your code and see whether I find a solution.
Can you share your changes with us?

Thank you very much and kind regards

Sorry for the late response @mtill, I can definitely do that!

@mtill This is all the code I've written for the issue so far. amaust@7f1d12c

[mtill]

Hi, don't we need to call "await this.textFileService.readStream" here to reload the content ?

Unfortunately, that does not seem to solve it. The error message still just stays present.

[mtill]

thanks for trying, @amaust
any hint/idea, @weartist ?
BR
mtill