When I press ctrl+tab to switch between open files, orca reads something like: Enter the name of an editor to open it

[jvesouza]

cc: @meganrogge @isidorn
Type: Bug

Steps to reproduce:

1. Open at least 2 files in VSCode.
2. Launch orca.
3. Press ctrl+tab to switch to the next open file.

In my environment orca announces something similar to the following:

Type the name of an editor to open it.

Is this the expected behavior?

VS Code version: Code - Insiders 1.78.0-insider (3e0b354, 2023-04-06T05:21:17.374Z)
OS version: Linux x64 6.2.8-200.fc37.x86_64
Modes:
Sandboxed: Yes

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz (8 x 2699)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: disabled_off direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: disabled_software vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: disabled_off
Load (avg)	2, 2, 1
Memory (System)	15.26GB (8.97GB free)
Process Argv	-n . --crash-reporter-id bc02adbd-6c3a-44b8-af92-55103a608af7
Screen Reader	yes
VM	0%
DESKTOP_SESSION	gnome-xorg
XDG_CURRENT_DESKTOP	GNOME
XDG_SESSION_DESKTOP	gnome-xorg
XDG_SESSION_TYPE	x11

Extensions (42)

Extension	Author (truncated)	Version
doxdocgen	csc	1.4.0
vscode-markdownlint	Dav	0.49.0
vscode-eslint	dba	2.4.0
EditorConfig	Edi	0.16.4
copilot	Git	1.79.10634
rest-client	hum	0.25.1
better-cpp-syntax	jef	1.17.2
docomment	k--	1.0.0
azure-pipelines	ms-	1.208.0
vscode-docker	ms-	1.24.0
csharp	ms-	1.25.4
vscode-dotnet-runtime	ms-	1.6.0
vscode-kubernetes-tools	ms-	1.3.11
remote-containers	ms-	0.289.0
remote-ssh	ms-	0.101.2023032915
remote-ssh-edit	ms-	0.84.0
azure-account	ms-	0.11.3
cmake-tools	ms-	1.13.45
cpptools	ms-	1.15.1
cpptools-extension-pack	ms-	1.3.0
makefile-tools	ms-	0.6.0
powershell	ms-	2023.3.3
remote-explorer	ms-	0.5.2023040509
vsliveshare	ms-	1.0.5834
oracledevtools	Ora	21.5.0
fabric8-analytics	red	0.3.6
java	red	1.17.2023040604
vscode-xml	red	0.25.2023032304
vscode-yaml	red	1.12.2
sonarlint-vscode	Son	3.16.0
cmake	twx	0.0.17
intellicode-api-usage-examples	Vis	0.2.7
vscodeintellicode	Vis	1.2.30
vscode-boot-dev-pack	vmw	0.2.1
vscode-spring-boot	vmw	1.45.0
vscode-java-debug	vsc	0.49.2023032407
vscode-java-dependency	vsc	0.21.2023032800
vscode-java-pack	vsc	0.25.2023032708
vscode-java-test	vsc	0.38.2023032402
vscode-maven	vsc	0.41.2023032803
vscode-spring-boot-dashboard	vsc	0.12.0
vscode-spring-initializr	vsc	0.11.2

(1 theme extensions excluded)

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492cf:30256198
vstes627cf:30244335
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30404738
cppdebug:30492333
vsclangdf:30492506
c4g48928:30535728
dsvsc012cf:30540253
pynewext54:30618038
pylantcb52:30590116
nodejswelcome1:30587009
pyind779:30611226
pythonsymbol12:30651887
6233i204:30659907
pythonb192:30661256
defaultazurewalk:30687958
pythonms35:30671666
cai9j608:30680470
24365598:30687740
pythonclientmv:30700173

[meganrogge]

This is happening because of the fix for #166920. I think it is behaving as designed, though will leave that with @TylerLeonhardt

[isidorn]

That's a bit weird. Since ctrl+tab experience does not visually render a placeholder. So I would not expect it gets read out.

[TylerLeonhardt]

Question is, should it say nothing, or is the aria-label for ctrl+tab not correct and it should be Select an editor to open?

I'm leaning "nothing" because otherwise they might have to hold down ctrl until the actual quick pick option highlighted is read out.

[TylerLeonhardt]

I have a fix out with the "nothing" idea... but would love to know what you folks think before I merge.

[jvesouza]

In version 1.77, when I press ctrl+tab, orca informs me that the focus has moved to a list box and the name of the next file is read.

Imagining the following scenario:

1. Open two files, a.js and b.js.
2. I start editing the a.js file.
3. I press ctlr+tab.

My screen reader reads the following information:
List Box, b.js.

In my view this behavior would be sufficient.

[jvesouza]

It is fixed, thanks.