Improve workbench start-up performance

[jrieken]

Startup performance for some users is very bad and we should understand why.

[bpasero]

Some ideas:

• add more numbers to our telemetry event for startup times to understand better where time is spend
• also log subsequent window opens as telemetry to see how bad we are with opening a second window when Code is already running (related: Make --performance flag work with opening a second window #11220)

[jrieken]

@bpasero Why is it that you instantiate all services eager during startup and don't let the instantiation service take care of this? The ServiceCollection also accepts ctor's which it will invoke when a service is being requested. While we still have to instantiate them all it might help getting the workbench show up faster

[bpasero]

@jrieken so instead of

this.viewletService = this.instantiationService.createInstance(ViewletService, this.sidebarPart);
serviceCollection.set(IViewletService, this.viewletService);

doing

serviceCollection.set(IViewletService, ViewletService);

?

There is no specific reason for instantiating all the services right on startup so we can try with it. Though many services are simply just interfaces for parts that get created on startup anyway (like the viewlet service).

[jrieken]

Like so, serviceCollection.set(IMenuService, new SyncDescriptor(MenuService));

I agree, some services are needed right aways or already instantiated but some aren't. My guess is that the lower half there can be lazy, like ConfigurationEditing