GIT_EDITOR set to `.sh` script on windows

[wookie184]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.69.0-insider (user setup)
• OS Version: Windows 11 Pro 22000

Steps to Reproduce:

1. Type $Env:GIT_EDITOR in vscode powershell terminal.
2. Notice that result is something like "c:\Users\wookie184\AppData\Local\Programs\Microsoft VS Code Insiders\resources\app\extensions\git\dist\git-editor.sh". AFAICT .sh files are not valid executables on windows so this doesn't make much sense.

This causes issues when running external tools (e.g. https://pypi.org/project/blurb/) which try and use GIT_EDITOR themselves. This can be avoided by disabling VSCode as your git editor ("git.useEditorAsCommitInput": false) but it would be nice to not have to do this.

I'll create an issue in blurb as well but I think it would be much better if it could be fixed here if possible as I'd guess there are many other tools that use GIT_EDITOR. (I don't think blurb could do much more than using a fallback if the env variable fails).

Thanks!

[lszomoru]

@wookie184, apologies for not gettig back to you on this. In the latest Stable and Insiders versions, the GIT_EDITOR environment variable should not be set by default in the integrated terminal. Could you please try the latest versions and see if you are still able to reproduce the problem by running $Env:GIT_EDITOR in the integrated terminal? This environment variable is only set if the git.terminalGitEditor is enabled.

[wookie184]

@wookie184, apologies for not gettig back to you on this. In the latest Stable and Insiders versions, the GIT_EDITOR environment variable should not be set by default in the integrated terminal. Could you please try the latest versions and see if you are still able to reproduce the problem by running $Env:GIT_EDITOR in the integrated terminal? This environment variable is only set if the git.terminalGitEditor is enabled.

Thanks for the reply.

That does prevent the issue, although my use case is more that I want to use VSCode as my git editor, but for the GIT_EDITOR env variable to also be usable by other applications to use VSCode as an editor in a similar way, if that's possible. In that sense it's more of a feature request than a bug.

[vscodenpa]

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[vscodenpa]

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

[vscodenpa]

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!