Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only show comment thread range when the comment is expanded #152067

Closed
alexr00 opened this issue Jun 14, 2022 · 0 comments · Fixed by #152206
Closed

Only show comment thread range when the comment is expanded #152067

alexr00 opened this issue Jun 14, 2022 · 0 comments · Fixed by #152206
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
June 2022

Comments

@alexr00
Copy link
Member

alexr00 commented Jun 14, 2022

The feedback has been that always showing the thread range is distracting. Instead, we should only show the range when the comment is expanded.
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues labels Jun 14, 2022
@alexr00 alexr00 added this to the June 2022 milestone Jun 14, 2022
@alexr00 alexr00 self-assigned this Jun 14, 2022
@alexr00 alexr00 mentioned this issue Jun 15, 2022
Merged
alexr00 added a commit that referenced this issue Jun 15, 2022
@alexr00
Only show comment thread range when the comment is expanded
89135d4 
Fixes #152067
alexr00 added a commit that referenced this issue Jun 15, 2022
@alexr00
Only show comment thread range when the comment is expanded (#152206)
6e1ea79 
Fixes #152067
@VSCodeTriageBot VSCodeTriageBot added the unreleased Patch has not yet been released in VS Code Insiders label Jun 15, 2022
@alexr00 alexr00 mentioned this issue Jun 15, 2022
Closed
@VSCodeTriageBot VSCodeTriageBot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 16, 2022
justschen pushed a commit to justschen/vscode that referenced this issue Jun 16, 2022
@alexr00 @justschen
Only show comment thread range when the comment is expanded (microsof…
5ad3e51 
…t#152206)

Fixes microsoft#152067
@connor4312 connor4312 added the verified Verification succeeded label Jun 30, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug comments Comments Provider/Widget/Panel issues insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

Only show comment thread range when the comment is expanded microsoft/vscode
3 participants
@connor4312 @alexr00 @VSCodeTriageBot