Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't drag an item and drop it to an empty treeview #149890

Closed
0x-jerry opened this issue May 19, 2022 · 2 comments · Fixed by #151213
Closed

Can't drag an item and drop it to an empty treeview #149890

0x-jerry opened this issue May 19, 2022 · 2 comments · Fixed by #151213
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-views Extension tree view issues verified Verification succeeded
Milestone
June 2022

Comments

@0x-jerry
Copy link

Does this issue occur when all extensions are disabled?: Yes

Version: 1.67.2
Commit: c3511e6
Date: 2022-05-17T18:20:57.384Z
Electron: 17.4.1
Chromium: 98.0.4758.141
Node.js: 16.13.0
V8: 9.8.177.13-electron.0
OS: Darwin x64 19.6.0

Sometimes, I can't drag an item and drop it into an empty tree view.

Reproduce step:

  1. pnpm install.
  2. Run Launch Extension task.
  3. Drag all items from viewA and drop them to viewB
  4. Then, drag any item from viewB and drop it to viewA (Can not drop it.)

minimal code to reproduce

FYI, sometimes, it can drag an item and drop it to an empty tree view, but I didn't change any code.

issue.mp4
@JacksonKearl JacksonKearl assigned alexr00 and unassigned JacksonKearl May 19, 2022
@0x-jerry 0x-jerry mentioned this issue May 19, 2022
Merged
@alexr00
Copy link
Member

alexr00 commented Jun 3, 2022

I can repro, thank you for the complete example!

@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jun 3, 2022
@alexr00 alexr00 added this to the June 2022 milestone Jun 3, 2022
@alexr00 alexr00 added the tree-views Extension tree view issues label Jun 3, 2022
@alexr00 alexr00 mentioned this issue Jun 3, 2022
Merged
alexr00 added a commit that referenced this issue Jun 3, 2022
@alexr00
Can't drag an item and drop it to an empty treeview
f106f1f 
Fixes #149890
alexr00 added a commit that referenced this issue Jun 7, 2022
@alexr00
Can't drag an item and drop it to an empty treeview (#151213)
6a58b40 
Fixes #149890
@VSCodeTriageBot VSCodeTriageBot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jun 7, 2022
@IanMatthewHuff IanMatthewHuff added the verified Verification succeeded label Jun 29, 2022
@IanMatthewHuff
Copy link
Member

Verified, thanks for providing the clear repro.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
June 2022
Development

Successfully merging a pull request may close this issue.

Can't drag an item and drop it to an empty treeview microsoft/vscode
5 participants
@IanMatthewHuff @JacksonKearl @0x-jerry @alexr00 @VSCodeTriageBot