Skip to content

Adopt selection support in notebook diff / interactive editor to enable in-editor history #142507

Open

Description

7858e23#diff-330f92e5612e8f9dcc91e85d694b6e10fdaa5f14c384157edfd27dfbbf0f8684 added support for selection in notebook editor to participate in history navigation by recording locations for each cell change. This is not yet adopted for these two:

  • NotebookTextDiffEditor
  • InteractiveEditor

Fyi for text diff editors we implemented this in a simple way by just delegating to the right hand (modified) side. This is not 100% correct because you could compare 2 different files via explorer where both sides are editable, but I have not heard complaints so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions