Relative paths and paths without columns not linked in debug console

[felixfbecker]

• VSCode Version: 1.5, 1.6 insider
• OS Version: Windows 10

Paths from the stack trace are not clickable

[felixfbecker]

Btw this also affects relative paths:

I would consider this more of a bug than a feature request, as it works correctly on the other OS. This is really slowing down productivity, please please consider this for the next iteration. I imagine it is just a wrong regexp somewhere.

[isidorn]

Here is a code pointer
PRs that fix this are welcome. If it turns out to be too complex I can look into fixing this in the future

[felixfbecker]

Thanks @isidorn I will take a look at this! Are there tests for this?

[isidorn]

@felixfbecker no but adding tests would be even more super awesome.
It should be possible to create a ReplExpressionsRenderer with a MockEditorService and test out the link detection. If this seems unintersting I can look into adding tests in one of our debt weeks.

P.S this is good documentation on how to run vscode out of source and immediatly try out your changes https://github.com/Microsoft/vscode/wiki/How-to-Contribute
This change should not break the existing OS X and linux behavior - not sure if you have those machines but I can check it on my VMs easily

[isidorn]

Also a bit related #6301

And make sure to get the very latest - now I polished the imports in that file so you might end up in merge conflicts if you start on a pr on an older code base.

[felixfbecker]

Fixed the regexp so that

• relative paths are matched (the "root" path is optional now)
• paths without a column are matched ("column" path is optional now, as PHP only reports line numbers)
• no line breaks and colons are allowed inside the path (otherwise change 2 would cause unintended matches)

Need to build VS Code now and find out if the match groups that may now be undefined cause any problems. Also need to test URIs.