Skip to content

Move extension host out of the workbench for process reuse #123592

Closed
@rzhao271

Description

@rzhao271

As part of #120431, we have to move the extension host out of the workbench.
Currently, the workbench is the parent of the extension host. When we do a reload, the workbench is recreated. When process reuse is enabled, the workbench PID stays the same throughout the reload, but the node environment is still taken down. Due to this cleanup, the child exit signal from the extension host is not handled, creating a zombie.
By moving the extension host out of the workbench, another longer-lived process can handle the signal instead.

@alexdima do you have any specific ideas as to how the new architecture should look?

Metadata

Metadata

Labels

debtCode quality issuesengineeringVS Code - Build / issue tracking / etc.extension-hostExtension host issuesinsiders-releasedPatch has been released in VS Code InsiderssandboxRunning VSCode in a node-free environment

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions