cursor keys not working for filtering in File Explorer

[alexlamsl]

Issue Type: Bug

https://code.visualstudio.com/docs/getstarted/userinterface#_filtering-the-document-tree

Before the latest update, after typing in File Explorer, the tree will scroll to the first match, and up/down key will jump between matches.

With the latest version, none of the above would happen.

VS Code version: Code 1.53.0 (8490d3d, 2021-02-03T20:36:38.611Z)
OS version: Windows_NT x64 10.0.14393

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-4960X CPU @ 3.60GHz (12 x 3602)
GPU Status	2d_canvas: unavailable_software gpu_compositing: disabled_software multiple_raster_threads: enabled_on oop_rasterization: disabled_off opengl: disabled_off protected_video_decode: disabled_off rasterization: disabled_software skia_renderer: enabled_on video_decode: disabled_software vulkan: disabled_off webgl: unavailable_software webgl2: unavailable_software
Load (avg)	undefined
Memory (System)	63.94GB (58.64GB free)
Screen Reader	no
VM	0%

Extensions: none

[gjsjohnmurray]

Are you sure that focus is on an item in the tree when you start typing?

[alexlamsl]

The brown filter text box appears and displays what I'm typing the same way as before, so yes I am pretty sure the focus is correct.

The only thing missing is the scrolling and the subsequent ability to navigate with arrow keys on the keyboard in the latest version.

[alexlamsl]

To clarify, the "Filter on Type" is off, i.e. files items won't disappear while I type, merely highlighting the matching items and allowing me to jump between them using up/down keys.

And that is what works previously but not so in the latest version.

[gjsjohnmurray]

/confirm

Thanks for the additional information. One of the dev team now needs to investigate when the regression occurred.

[jeanp413]

This is a regression from 37a4b96 where the FuzzyScore.isDefault wasn't updated.
Created a PR #116005 fixing it

[isidorn]

@jeanp413 thanks a lot for fixing!
Assigning this one to @jrieken since his commit caused the regression it seems

[jrieken]

@isidorn your call whether this is severe enough to be a recovery candidate or not