Skip to content

Commit

Permalink
[Backport] Fix built-in walkthroughs rendering (#179335)
Browse files Browse the repository at this point in the history
Fix built-in walkthroughs rendering
  • Loading branch information
bhavyaus authored Apr 11, 2023
1 parent 7874d47 commit 7830ea6
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -242,6 +242,7 @@ export class GettingStartedPage extends EditorPane {
}
}));

this._register(this.gettingStartedService.onDidAddBuiltInWalkthrough(rerender));
this._register(this.gettingStartedService.onDidAddWalkthrough(rerender));
this._register(this.gettingStartedService.onDidRemoveWalkthrough(rerender));

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,7 @@ export interface IWalkthroughsService {
readonly onDidRemoveWalkthrough: Event<string>;
readonly onDidChangeWalkthrough: Event<IResolvedWalkthrough>;
readonly onDidProgressStep: Event<IResolvedWalkthroughStep>;
readonly onDidAddBuiltInWalkthrough: Event<void>;

readonly installedExtensionsRegistered: Promise<void>;

Expand Down Expand Up @@ -134,6 +135,9 @@ export class WalkthroughsService extends Disposable implements IWalkthroughsServ
private readonly _onDidProgressStep = new Emitter<IResolvedWalkthroughStep>();
readonly onDidProgressStep: Event<IResolvedWalkthroughStep> = this._onDidProgressStep.event;

private readonly _onDidAddBuiltInWalkthrough = new Emitter<void>();
readonly onDidAddBuiltInWalkthrough: Event<void> = this._onDidAddBuiltInWalkthrough.event;

private memento: Memento;
private stepProgress: Record<string, StepProgress | undefined>;

Expand Down Expand Up @@ -255,6 +259,8 @@ export class WalkthroughsService extends Disposable implements IWalkthroughsServ
})
});
});

this._onDidAddBuiltInWalkthrough.fire();
}

private updateWalkthroughContent(walkthrough: BuiltinGettingStartedCategory, experimentTreatment: WalkthroughTreatment): BuiltinGettingStartedCategory {
Expand Down

0 comments on commit 7830ea6

Please sign in to comment.