minor internal request/queue type fixes #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a no-op, since the parameter was never given differently than its default value, other than in recursive contexts. That parameter was counter-abstract and only coincidentally common between buildProcessTree and filterProcessList. If the value were ever to be changeable, it should be as a bound parameter on the supplied transform, e.g. `(pid, list) => buildProcessTree(pid, list, 320)` Didn't belong on getRawProcessList.
The types here were confused: the *callback* can be given `undefined`,
due to the intermediate transforms ("filter") returning that value if
the root pid could not be found.
Tyriar
approved these changes
Nov 9, 2022
rzhao271
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor (internal) type fixes. In current
main, the types incorrect: for examplegetRawProcessListspecifies a callback that can accept eitherIProcessInfo[] | IProcessTreeNode, which none of them do.This straightens it out, along with some related minor cleanups.