Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

Conversation

hawkticehurst
Copy link
Member

@hawkticehurst hawkticehurst commented Mar 3, 2022

Link to relevant issue

This pull request resolves #276

Description of changes

This PR pulls in an upstream change from fast-foundation that updates data grid default behavior so that data grid columns take an equal amount of width.

This new default behavior should hopefully resolve any alignment issues that toolkit users were running into.

The upstream changes also mean that manually defined data grids no longer need to include generate-header="none".

@hawkticehurst hawkticehurst changed the title Automatically generate grid template columns in data grids Automatically set data grid template columns to have equal width Mar 3, 2022
@hawkticehurst hawkticehurst changed the title Automatically set data grid template columns to have equal width Automatically set data grid columns to have equal width Mar 3, 2022
Copy link
Collaborator

@daviddossett daviddossett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Woo!

@hawkticehurst hawkticehurst merged commit c804fab into microsoft:main Mar 3, 2022
@hawkticehurst hawkticehurst deleted the data-grid-column-template branch March 3, 2022 19:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

data-grid: cells are not aligned

2 participants