Fix high contrast theme bugs #326
Conversation
…high contrast theme is used
… outlines were not being rendered due to incorrect CSS selector formatting
…heme bugs in the data grid and icon button components
| * in the applyTheme function) but does not have a corresponding VS Code token that can be used. | ||
| * | ||
| * An example is buttonIconHoverBackground token which does not have a corresponding VS Code token | ||
| * at this time (it's a hardcoded value in VS Code), but needs to be adjusted to be transparent when a |
There was a problem hiding this comment.
Should this be an issue filed on /vscode? If it's a simple enough change I can add it to my list
There was a problem hiding this comment.
I wouldn't be against that! Would certainly simplify the toolkit theming code
There was a problem hiding this comment.
The big request is that this token should either be set to transparent or null (not exist) in high contrast themes
There was a problem hiding this comment.
Otherwise, its value seems to be rgba(90, 93, 94, 0.31) across all themes?
There was a problem hiding this comment.
As I think about it, this could actually be a really nice opportunity to customize things a bit because I think this value ends up resulting in a slightly less than ideal contrast ratio in light themes
2 participants
Link to relevant issue
This pull request resolves #286
Description of changes
Fixes a variety of component theming bugs when VS Code uses a high contrast theme. A list of the various bugs can be found in the issue linked above.