This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Update Package To Be Side Effects Free #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SSDesignTokens and initializes the VS Code theme listener
…function calls of some design tokens to include VS Code theme variables
|
@connor4312 Adding you as an optional PR reviewer since you've been a lot of help in the implementation of this PR and it would be great to get any final feedback from you on this. But also no pressure if you don't have the time or don't want to review in general. |
daviddossett
approved these changes
Oct 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to relevant issue
This pull request resolves #253
Description of changes
Updates the way that design tokens and VS Code theme listening/application is accomplished so the toolkit no longer has any side effects.
Also, add
sideEffects: falsetopackage.json.