Skip to content
This repository was archived by the owner on Jan 6, 2025. It is now read-only.
This repository was archived by the owner on Jan 6, 2025. It is now read-only.

React peer dependency required for some web-component-only extensions to build #329

@hawkticehurst

Description

@hawkticehurst

Describe the bug

Bubbling this issue up from the VS Code community Slack.

A toolkit dev ran into an issue where their extension failed to build because the fast-react-wrapper toolkit dep requires react as a peer dependency despite the fact that their extension only uses the vanilla web components.

This issue only seems to occur when using a build tool (like Webpack) to bundle/build extensions because using toolkit.min.js provided a stop-gap solution for the dev.

To reproduce

Forthcoming

Expected behavior

Building an extension that only uses WCs should not fail because of a required peer dep to react.

Screenshots

Screen Shot 2022-02-08 at 12 57 59 PM

Desktop (please complete the following information):

  • OS Version: n/a
  • Toolkit Version: v0.9.0

Additional context

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions