Absolute rule reference use local scope

[hediet]

I think this line:

vscode-textmate/src/grammar.ts

Line 147 in 9157c7f

collectSpecificDependencies(result, baseGrammar, baseGrammar, includedName, patternRepository);

should rather be this:

collectSpecificDependencies(result, baseGrammar, baseGrammar, includedName, baseGrammar.repository);

Also, this line:

vscode-textmate/src/grammar.ts

Line 149 in 9157c7f

collectSpecificDependencies(result, baseGrammar, selfGrammar, includedName, patternRepository);

should be this:

collectSpecificDependencies(result, baseGrammar, selfGrammar, includedName, selfGrammar.repository);

---

Let's say source.md embeds source.css and a rule in source.css references source.md#link.
Then with the logic in main, a rule in source.css referencing source.md#link would look up link in its local repository (first repositories of this rule or parent rules, then the repository of source.css), but not in the repository of source.md.

[RedCMD]

I'm cant seem to picture what you're trying to explain
can you provide an example please?

I think we can agree that source.md#link should always include the #link key from inside source.md and never anywhere else
Even if called from source.css or source.md

But if source.css tries to include #link, it should look inside its own repo first; before searching out in source.md?

source.md
├ source.md#link
└ source.css
 └ source.css#link

[hediet]

This is the failing test case (marked as skipped):

vscode-textmate/src/tests/grammar.test.ts

Lines 108 to 142 in e8d1fc5

	test.skip('Shadowed rules are resolved correctly', async function () {
	const registry = new Registry({ loadGrammar: async () => undefined, onigLib: getOniguruma() });
	try {
	const grammar = await registry.addGrammar({
	scopeName: 'source.test',
	repository: {
	$base: undefined!,
	$self: undefined!,
	foo: { include: '#bar', },
	bar: { match: 'bar1', name: 'outer' }
	},
	patterns: [
	{
	patterns: [{ include: '#foo' }],
	repository: {
	$base: undefined!,
	$self: undefined!,
	bar: { match: 'bar1', name: 'inner' }
	}
	},
	// When you move this up, the test passes
	{
	begin: 'begin',
	patterns: [{ include: '#foo' }],
	end: 'end'
	},
	]
	});
	const result = grammar.tokenizeLine('bar1', null, undefined);
	// TODO this should be inner!
	assert.deepStrictEqual(result.tokens, [{ startIndex: 0, endIndex: 4, scopes: ["source.test", "outer"] }]);
	} finally {
	registry.dispose();
	}
	});