Skip to content

Conversation

taylorkline
Copy link
Contributor

Instructs user where to update setttings.json for folder, workspace, and/or global where relevant.

The current instructions were quite vague:

To specify a subfolder in which the react-native project is located, set react-native-tools.projectRoot. You can use either an absolute or relative path here

I though this needed to be in a file named react-native-tools.projectRoot but wherever I placed it, it had no effect.

With these jsonc comments we can tell the user that these are blocks of code to add to the appropriate settings.json.

Suggests updating `setttings.json` for folder, workspace, and/or global where relevant.
@JiglioNero
Copy link
Contributor

JiglioNero commented Jun 10, 2022

Hi @taylorkline, and thank you for contributing. Yes, some instructions don't specify what is related to settings.json. But I think that it is possible to specify it in the explanation before the corresponding pieces of JSON. For example:
There are also some global extension technical logs that might be exposed to the output. To see them, set the following properties in the settings.json file: ...
As for clarifying where the settings.json file is located - I'm not sure if this is necessary, because there is a UI representation of the VS Code settings with the possibility of separate workspace settings:

image

@taylorkline
Copy link
Contributor Author

@JiglioNero Updated based on your feedback!

@Samriel Samriel merged commit 90725dc into microsoft:master Jun 27, 2022
@Samriel
Copy link
Contributor

Samriel commented Jun 27, 2022

@taylorkline, sorry we kept you waiting and thanks for contributing to the project!

@taylorkline taylorkline deleted the patch-1 branch June 27, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants