Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch over to executeCommand from sendText #24078

Merged
merged 37 commits into from
Sep 12, 2024
Merged

Switch over to executeCommand from sendText #24078

merged 37 commits into from
Sep 12, 2024

Commits on Sep 9, 2024

  1. vscode engine to 1.93

    @anthonykim1
    anthonykim1 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    2413118 View commit details
    Browse the repository at this point in the history

  2. use executeCommand

    @anthonykim1
    anthonykim1 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    5de9ca5 View commit details
    Browse the repository at this point in the history

  3. codeaction mock

    @anthonykim1
    anthonykim1 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6d1f522 View commit details
    Browse the repository at this point in the history

  4. compile

    @anthonykim1
    anthonykim1 committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    c9fc4f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2024

  1. switching version allows debugging - magically

    @anthonykim1
    anthonykim1 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    0d78806 View commit details
    Browse the repository at this point in the history

  2. pin version to equal to or above 1.93

    @anthonykim1
    anthonykim1 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    a16a102 View commit details
    Browse the repository at this point in the history

  3. try to fix unit test

    @anthonykim1
    anthonykim1 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    ea24d50 View commit details
    Browse the repository at this point in the history

  4. Debt: switch Promise<void> in ensureTerminal to Promise<Terminal>

    @anthonykim1
    anthonykim1 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    2cb1eb3 View commit details
    Browse the repository at this point in the history

  5. passing test when shell integration disabled

    @anthonykim1
    anthonykim1 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    88b4e9f View commit details
    Browse the repository at this point in the history

  6. please

    @anthonykim1
    anthonykim1 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    6ecf4fc View commit details
    Browse the repository at this point in the history

  7. // @ts-ignore: TS6133

    @anthonykim1
    anthonykim1 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    831f893 View commit details
    Browse the repository at this point in the history

  8. a

    @anthonykim1
    anthonykim1 committed Sep 10, 2024
    Configuration menu
    Copy the full SHA
    f3aa28e View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2024

  1. stop

    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    342587a View commit details
    Browse the repository at this point in the history

  2. try idisposable

    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3efaf9a View commit details
    Browse the repository at this point in the history

  3. more trials

    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d3b2238 View commit details
    Browse the repository at this point in the history

  4. lint

    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    28ef3c1 View commit details
    Browse the repository at this point in the history

  5. slowly migrate test from sendText to executeCommand

    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    2375490 View commit details
    Browse the repository at this point in the history

  6. TODO: test for when shellIntegration is active, mock and fire onDidEn… 

    …dTerminalShellExecution
    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a75656b View commit details
    Browse the repository at this point in the history

  7. onDidEndTerminalShellExecution never gets fired

    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    a51b6b4 View commit details
    Browse the repository at this point in the history

  8. switch up the order

    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    7c01537 View commit details
    Browse the repository at this point in the history

  9. add test onDidEndTerminalShellExecutionEmitter.fire(event)

    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    923df5c View commit details
    Browse the repository at this point in the history

  10. attach callback to executeCommand so onDidEndTerminalShellExecutionEm… 

    …itter fires
    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    16839c9 View commit details
    Browse the repository at this point in the history

  11. switch up the order abit + comment

    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e30bb77 View commit details
    Browse the repository at this point in the history

  12. wow

    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e69c490 View commit details
    Browse the repository at this point in the history

  13. remove junk

    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e2e71d0 View commit details
    Browse the repository at this point in the history

  14. remove unused

    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    3d31d1a View commit details
    Browse the repository at this point in the history

  15. remove comment

    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    46d28d2 View commit details
    Browse the repository at this point in the history

  16. TODO: smart send smoke test are flaky on windows

    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    5d3878f View commit details
    Browse the repository at this point in the history

  17. a

    @anthonykim1
    anthonykim1 committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    dfe61de View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. take recommended feedbacks

    @anthonykim1
    anthonykim1 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8f9ab0d View commit details
    Browse the repository at this point in the history

  2. remove leftover comments - done

    @anthonykim1
    anthonykim1 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    6d095c8 View commit details
    Browse the repository at this point in the history

  3. final

    @anthonykim1
    anthonykim1 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    563fb12 View commit details
    Browse the repository at this point in the history

  4. remove weird import

    @anthonykim1
    anthonykim1 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    145e2fd View commit details
    Browse the repository at this point in the history

  5. last missed comment

    @anthonykim1
    anthonykim1 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8bc3951 View commit details
    Browse the repository at this point in the history

  6. upgrade actions/download-artifact@v4

    @anthonykim1
    anthonykim1 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    610d0fb View commit details
    Browse the repository at this point in the history

  7. why

    @anthonykim1
    anthonykim1 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c6a4713 View commit details
    Browse the repository at this point in the history

  8. try with actions/download-artifact@v3

    @anthonykim1
    anthonykim1 committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    2b4c2bf View commit details
    Browse the repository at this point in the history