Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly track native REPL state #23997

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Conversation

anthonykim1
Copy link

Resolves: #23996

@anthonykim1 anthonykim1 added bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary labels Aug 26, 2024
@anthonykim1 anthonykim1 self-assigned this Aug 26, 2024
@anthonykim1 anthonykim1 marked this pull request as ready for review August 26, 2024 20:47
@vs-code-engineering vs-code-engineering bot added this to the August 2024 milestone Aug 26, 2024
@anthonykim1 anthonykim1 marked this pull request as draft August 26, 2024 20:50
@anthonykim1 anthonykim1 reopened this Aug 26, 2024
@anthonykim1 anthonykim1 changed the title set native repl to undefined when closed Correctly track native REPL state Aug 26, 2024
@anthonykim1 anthonykim1 marked this pull request as ready for review August 26, 2024 21:03
andreamah
andreamah previously approved these changes Aug 26, 2024
andreamah
andreamah previously approved these changes Aug 26, 2024
@anthonykim1 anthonykim1 marked this pull request as draft August 26, 2024 21:18
@anthonykim1 anthonykim1 marked this pull request as ready for review August 26, 2024 21:33
@anthonykim1 anthonykim1 merged commit 7ccf01e into microsoft:main Aug 26, 2024
40 checks passed
anthonykim1 added a commit to anthonykim1/vscode-python that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl bug Issue identified by VS Code Team member as probable bug skip tests Updates to tests unnecessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correctly track Native REPL via watching onClosed event
3 participants