Check that Python binary path is a file #21711
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current validation checks path's existence and name (basename must start with 'python'), which results in false positives when a virtualenv directory name starts with 'python' (e.g. ~/venv/python-3.11/bin/python results in ~/venv/python-3.11 being validated as the binary path).
karthiknadig
added
the
bug
karrtikr
reviewed
Aug 4, 2023
There was a problem hiding this comment.
Thanks for attempting a PR, however this behavior is intentional. Using "statSync" is relatively more resource-intensive compared to "existsSync", and synchronous methods can potentially block the event loop. Which is why the check is simplistic for now, as this code is called a bunch of times and is expected to be fast.
Feel free to open a new issue if you feel the need for this based on symptoms you see, and we can possibly explore alternatives depending on whether we want to support these cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current validation checks path's existence and name (basename must start with 'python'), which results in false positives when a virtualenv directory name starts with 'python' (e.g. ~/venv/python-3.11/bin/python results in ~/venv/python-3.11 being validated as the binary path).