Declare limited support for untrusted workspaces by only supporting Pylance

[karrtikr]

Closes #16126

For https://github.com/microsoft/vscode-python-internalbacklog/issues/394 closes #18031

Based on #17519

[heejaechang]

@karrtikr what would be best way for me to test it? can I download vsix?

[karrtikr]

@heejaechang Yep you can use the VSIX from the latest run, which is https://github.com/microsoft/vscode-python/suites/4321020335/artifacts/113044846.

[jakebailey]

Proposed? Is this not in their stable API?

[karrtikr]

It is but updating vscode types involves a lot of stuff #17656, so we're temporarily going with this hack.

[heejaechang]

I installed the vsix and tried on untrusted path and python extension is disabled?

pylance correctly show untrusted workspace thing

as we set in package.json

 "capabilities": {
        "untrustedWorkspaces": {
            "supported": "limited",
            "description": "Python will not be executed; the latest Python version will be used for analysis and installed libraries will not be available."
        },

but python extension is just plain disabled.

[karrtikr]

Weird, it activates just fine for me. Does your extension version and the package.json message match?

[heejaechang]

@karrtikr let me try again with vsix in this PR

[heejaechang]

@karrtikr alright, it works as expected once I re-installed vsix from latest build. I tested a bit and Pylance works as expected.

[heejaechang]

@karrtikr I tested virtual workspace as well (with GitHub Repositories extension), mostly it works as expected. but internally, there seems some stuff Pylance need to sort out (mostly around uri and file system access) but end user experience seems mostly what we would expect.

except one thing. even in virtual workspace scenario, trusted workspace concept seems to apply as you can see below

that I can make trusted

and status bar change to this

I am not sure what it meant to be trusted in virtual workspace environment. usually trusted means not file access but permission to execute exe (ex, python). are we going to let user to choose python (including venv) that are installed on local machine with virtual workspace?

code seems doesn't care about virtual workspace when passing python path though but only care about whether it is trusted or not. (and vscode code seems let user to trust virtual workspace).

[karrtikr]

Thanks for testing this!

are we going to let user to choose python (including venv) that are installed on local machine with virtual workspace?

Yep we discussed it here #17519 (comment), that way users can hover over the libraries they have installed for a particular interpreter. There's no reason to block it AFAICS, do you see any potential issues?