Skip to content

Remove python.condaPath from workspace scope #17820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
karrtikr merged 3 commits into from
Oct 21, 2021
Merged

Remove python.condaPath from workspace scope #17820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6192c1f
Remove `python.condaPath` from workspace scope
Oct 20, 2021
bfa93c9
News entry
Oct 20, 2021
a29a305
Update scope in tests
Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/2 Fixes/17819.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Remove `python.condaPath` from workspace scope.
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@
"python.condaPath": {
"default": "",
"description": "Path to the conda executable to use for activation (version 4.4+).",
"scope": "resource",
"scope": "machine",
"type": "string"
},
"python.defaultInterpreterPath": {
Expand Down
4 changes: 2 additions & 2 deletions ...est/common/terminals/environmentActivationProviders/terminalActivation.testvirtualenvs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ suite('Activation of Environments in Terminal', () => {
defaultShell.Linux,
vscode.ConfigurationTarget.Global,
);
await pythonSettings.update('condaPath', undefined, vscode.ConfigurationTarget.Workspace);
await pythonSettings.update('condaPath', undefined, vscode.ConfigurationTarget.Global);
if (experiments.inExperimentSync(DeprecatePythonPath.experiment)) {
await resetGlobalInterpreterPathSetting();
} else {
Expand Down Expand Up @@ -204,7 +204,7 @@ suite('Activation of Environments in Terminal', () => {
'Command Prompt',
vscode.ConfigurationTarget.Global,
);
await pythonSettings.update('condaPath', envPaths.condaExecPath, vscode.ConfigurationTarget.Workspace);
await pythonSettings.update('condaPath', envPaths.condaExecPath, vscode.ConfigurationTarget.Global);
await testActivation(envPaths.condaPath);
}).timeout(TEST_TIMEOUT * 2);
});